fix: Fix scanning google cloud with service account credentials file #19782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
commented
Nov 14, 2024
| scopes=( | ||
| scopes | ||
| if scopes is not None | ||
| else ["https://www.googleapis.com/auth/cloud-platform"] |
There was a problem hiding this comment.
We need to pass this URL into scopes - https://stackoverflow.com/a/74562563
nameexhaustion
commented
Nov 14, 2024
| "cloudpickle", | ||
| "connectorx", | ||
| "deltalake", | ||
| "fastexcel", | ||
| "fsspec", | ||
| "gevent", | ||
| "google.auth", |
There was a problem hiding this comment.
drive-by print the boto3 and google-auth package versions in show_versions(), since we could be using them now
ritchie46
approved these changes
Nov 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19782 +/- ##
=======================================
Coverage 79.55% 79.56%
=======================================
Files 1544 1544
Lines 213240 213338 +98
Branches 2441 2442 +1
=======================================
+ Hits 169645 169735 +90
- Misses 43046 43053 +7
- Partials 549 550 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19781