perf: Move row group decode off async thread for local streaming parquet scan #19828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
commented
Nov 17, 2024
| /// Run a task on the rayon threadpool. To avoid deadlocks, if the current thread is already a | ||
| /// rayon thread, the task is executed on the current thread after tokio's `block_in_place` is | ||
| /// used to spawn another thread to poll futures. | ||
| pub async fn spawn_rayon<F, O>(&self, func: F) -> O |
There was a problem hiding this comment.
Made this a function, but I think we won't be using it much as we move to the new streaming engine.
23dd909
to
a4e367f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19828 +/- ##
==========================================
+ Coverage 79.33% 79.34% +0.01%
==========================================
Files 1548 1548
Lines 214208 214192 -16
Branches 2460 2460
==========================================
+ Hits 169934 169943 +9
+ Misses 43716 43691 -25
Partials 558 558 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we don't block tokio threads on compute.