docs: Fix some warnings during docs build #19848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19848 +/- ##
==========================================
+ Coverage 79.37% 79.39% +0.02%
==========================================
Files 1550 1550
Lines 214743 214840 +97
Branches 2460 2460
==========================================
+ Hits 170457 170582 +125
+ Misses 43727 43699 -28
Partials 559 559 ☔ View full report in Codecov by Sentry. |
rodrigogiraoserrao
requested changes
Nov 18, 2024
32d48db
to
5bde56e
Compare
| @@ -130,7 +134,10 @@ | |||
| schema_overrides={"species": pl.Categorical}, | |||
| ) | |||
|
|
|||
| bears = pl.concat([male_bears, female_bears], how="vertical") | |||
| with warnings.catch_warnings(): | |||
| warnings.filterwarnings("ignore", category=CategoricalRemappingWarning) | |||
There was a problem hiding this comment.
Oh, this (setting the filter) is still needed? 😪
There was a problem hiding this comment.
rodrigogiraoserrao
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI failure unrelated (VSCode marketplace URL is flaky).