fix: Incorrect explode schema for LazyFrame.explode()
#19860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
commented
Nov 19, 2024
| @@ -133,7 +133,7 @@ def test_schema_functions_in_agg_with_literal_arg_19011() -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def test_lf_explode_in_agg_schema_19562() -> None: | |||
| def test_lazy_explode_in_agg_schema_19562() -> None: | |||
There was a problem hiding this comment.
drive-by rename test_lf_* -> test_lazy_*
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19860 +/- ##
==========================================
- Coverage 79.42% 79.39% -0.03%
==========================================
Files 1550 1550
Lines 214853 214857 +4
Branches 2447 2447
==========================================
- Hits 170655 170596 -59
- Misses 43641 43704 +63
Partials 557 557 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ritchie46
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes through a different codepath than the
Exprexplode. We will be correct in bothExprandLazyFrameexplode after this PR 🙂Fixes #19763