Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Minor non-breaking space ( ) tweak for HTML rendering #19864

Merged

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Nov 19, 2024

Closes #19859.

Note: the related Issue isn't a Polars bug, it's a configurable setting in JetBrains IDEs.

However, we don't need to substitute all spaces in the HTML output in order to preserve whitespace, just consecutive ones (eg: two or more adjacent spaces). This adjustment will tidy-up HTML table rendering in IDEs where showing special characters is the default.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Nov 19, 2024
@alexander-beedie alexander-beedie changed the title refactor(python): Minor   cleanup for HTML rendering refactor(python): Minor non-breaking space ( ) cleanup for HTML rendering Nov 19, 2024
@alexander-beedie alexander-beedie changed the title refactor(python): Minor non-breaking space ( ) cleanup for HTML rendering refactor(python): Minor non-breaking space ( ) tweak for HTML rendering Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (282ed31) to head (e07418f).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19864      +/-   ##
==========================================
+ Coverage   79.43%   79.44%   +0.01%     
==========================================
  Files        1550     1550              
  Lines      214976   215086     +110     
  Branches     2447     2447              
==========================================
+ Hits       170763   170877     +114     
+ Misses      43656    43652       -4     
  Partials      557      557              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey look, it's the regex master himself 😄

@alexander-beedie alexander-beedie merged commit 4af1c43 into pola-rs:main Nov 22, 2024
21 checks passed
@alexander-beedie alexander-beedie deleted the html-nbsp-replacement branch November 22, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strings showing non-breaking space in PyCharm Jupyter Notebooks after 1.14 upgrade
2 participants