fix: Fix panic using scan_parquet().with_row_index() with hive partitioning enabled
#19865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scan_parquet().with_row_index() with hive partitioning enabled.scan_parquet().with_row_index() with hive partitioning enabled
nameexhaustion
commented
Nov 19, 2024
| let mut schema_idx_arr = [ | ||
| reader_schema.index_of(series_arr[0][0].name()).unwrap(), | ||
| // `unwrap_or(0)`: The first column could be a row_index column that doesn't exist in the `reader_schema`. | ||
| reader_schema.index_of(series_arr[0][0].name()).unwrap_or(0), |
There was a problem hiding this comment.
Fix is here
858c46e
to
43e4518
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19865 +/- ##
==========================================
+ Coverage 79.40% 79.44% +0.03%
==========================================
Files 1550 1550
Lines 214909 215086 +177
Branches 2447 2447
==========================================
+ Hits 170653 170868 +215
+ Misses 43699 43661 -38
Partials 557 557 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19861
This error occurs in the merge operation for the case where hive columns are also present in the data file and a
with_row_index()is requested.