Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AhoCorasick backed 'find_many' #19952

Merged
merged 2 commits into from
Nov 24, 2024
Merged

feat: Add AhoCorasick backed 'find_many' #19952

merged 2 commits into from
Nov 24, 2024

Conversation

ritchie46
Copy link
Member

closes #19923

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.46%. Comparing base (ce32455) to head (aae90d2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../polars-ops/src/chunked_array/strings/find_many.rs 73.07% 14 Missing ⚠️
...rates/polars-plan/src/dsl/function_expr/strings.rs 95.45% 1 Missing ⚠️
.../polars-python/src/lazyframe/visitor/expr_nodes.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #19952    +/-   ##
========================================
  Coverage   79.45%   79.46%            
========================================
  Files        1555     1555            
  Lines      216168   216286   +118     
  Branches     2456     2456            
========================================
+ Hits       171765   171867   +102     
- Misses      43845    43861    +16     
  Partials      558      558            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ritchie46 ritchie46 merged commit 8d9ed64 into main Nov 24, 2024
26 checks passed
@ritchie46 ritchie46 deleted the find_many branch November 24, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a .str.find_many with AhoCorasick (similar to extract_many)
1 participant