Match FIPS implementation between sdk v1 and sdk v2 #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82ad660
to
acfee4f
Compare
cristiangreco
approved these changes
Aug 23, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mirrors the aws sdk v1 FIPS implementation to sdk v2. FIPS is enabled per client when running with FIPS enabled. I originally tried keeping the FIPS setting at the root config and explicitly disabling it for clients which did not support it. But testing showed the root config value takes precedence over client specific values.
As a part of double checking FIPS support on the services, I noticed Amazon Managed Prometheus does not appear to have any FIPS support on https://aws.amazon.com/compliance/fips/. I removed support for enabling FIPS is sdk v1 and v2.
The base branch is #1115 ATM since both PRs touch the sdk v2 client configs. I'll rebase this one after the retry setting is merged.Resolves: #966