Change UpdateMetrics signature to accept options and return error. #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0484fb3
to
3920f35
Compare
Refactor the signature of `UpdateMetrics` (entry point if you use yace as a library) to accept a variadic list of options funcs rather than a lengthy list of parameters, and to return an error (currently always nil, but will be used to bubble up errors from the pkg code).
3920f35
to
4880f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the signature of
UpdateMetrics(entry point if you use yace as a library) to accept a variadic list of options funcs rather than a lengthy list of parameters, and to return an error (currently always nil, but will be used to bubble up errors from the pkg code).