PLANNING ISSUE: Upgrade to Rails 5.0

[Souravirus]

This is only an initial planning writeup.

Things to be done before the upgrade

• Making a new branch for the upgrade.
• Working on tests

Things to be done during the transitions

• Changing the Gemfile
• Working for the Gems which are not available
• Adding tests where there is no availability of a good test coverage
• using http://railsdiff.org/4.2.10/5.0.7
• fixing all errors, failures and depreciation warnings
• following the steps of http://guides.rubyonrails.org/upgrading_ruby_on_rails.html
• 4.1 Ruby 2.2.2+ required
• 4.2 Active Record Models Now Inherit from ApplicationRecord by Default

Things to be done after the transitions

• Upgrading documentation and readme etc., about the changes done
• Fixing operational problems if any
• Removing obsolete code if any

@jywarren @siaw23 @publiclab/reviewers Please verify these steps and please comment any other steps that you want to add.
Excited to start coding.
It would be nice if any @publiclab/reviewers could add some labels to this issue like gsoc, planning, help wanted, etc.

[siaw23-retired]

Looks good to me except there's no mention of system tests. Might be out of the scope of this project but it'll mean we have to tread carefully. Also it'll be nice to get a test coverage for this otherwise it'll look like we don't know what we're doing. This could break or make things, tests coverage will help us gauge our confidence for refactoring. I'd like to remind you to do incremental upgrades instead of big jump between upgrades. RailsDiff will help with that.

[Souravirus]

Yeah I will surely go for an incremental upgrade. I think I should give some days for test coverage first. I should see if there are places which are out of tests and add tests to them. Although I have mentioned about the tests in the issue but still I should give some initial days for tests. What say?

[jywarren]

This is looking great. Maybe make 2 categories for things that can be done in advance of the switch vs. things which can only happen after? (and/or things that can happen in transition if any exist?) Looking great!

…

On Fri, May 11, 2018 at 7:42 AM, Sourav Sahoo ***@***.***> wrote: Yeah I will surely go for an incremental upgrade. I think I should give some days for test coverage first. I should see if there are places which are out of tests and add tests to them. What say? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2714 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ9j4QQxXGHmZ0dJ7lCexOoNxyuO3ks5txXkjgaJpZM4T65Q7> .

[Souravirus]

Hey @jywarren modified the issue as you wanted. Please check it once and comment any other things you want to add in the issue. Thanks!!

[jywarren]

Great! And @Souravirus you should be a reviewer! Have you made a first-timers-only issue before (forgive me if I forgot...). I'll invite you now, and I'm sure you've seen this page but please give it a look-over again as we encourage reviewers to be welcoming and helpful to newcomers!

http://publiclab.org/software-outreach

I'll invite you to be a reviewer :-) and happy to review a FTO issue if you want to try making one!

[Souravirus]

thanks @jywarren for making me a reviewer. No, I have still not made a first-timers-only , but would love to make one. when I find any first-timers issue in my project.

[jywarren]

Great! I'm happy to help. It's often the case that you have to break down your work to find some good ones, and it's really worth it to expand our team!

…

On Sat, May 12, 2018, 9:38 AM Sourav Sahoo ***@***.***> wrote: thanks @jywarren <https://github.com/jywarren> for making me a reviewer. No, I have still not made a first-timers-only, but would love to make one. when I find any first-timers issue in my project. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2714 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ_f3F9cjSSHC4Zoyg33qUyZMBChQks5txuWmgaJpZM4T65Q7> .

[jywarren]

Are we done with this issue now? Any of these follow-ups you want to try? Perhaps some could be good first-timers-only issues. 👍 👍 👍

[Souravirus]

Yeah this issue is done. I had sent a PR related to a follow up fix on #2794. I had a update in README.md where I thought to update the testing command to rails test -d. It will also serve as a first timer issue. What do you think @jywarren

[jywarren]

Sure! And you can close this once you're ready. What are you thinking of as next steps? 5.x? :-)

…

On Fri, Jun 8, 2018, 3:08 PM Sourav Sahoo ***@***.***> wrote: Yeah this issue is done. I had sent a PR related to a follow up fix on #2794 <#2794>. I had a update in README.md where I thought to update the testing command to 'rails test -d'. I will also serve as a first timer issue. What do you think @jywarren <https://github.com/jywarren> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2714 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ27dF-g3ClCP7ZNgF8CvrTGko-Ssks5t6suMgaJpZM4T65Q7> .

[Souravirus]

I will be working on upgrade of rails 5.1 upgrade

[Souravirus]

ok I am opening a new first timers issue related to the testing command.

[jywarren]

Want to close this then? Maybe you should open a new milestone to track your progress for the summer now that you've completed this planning issue? That way it can be a collection of loosely related issues.

[Souravirus]

Yeah closing