Fix: updated First timers issue template url and changed the location of "templet for opening a issue".#10633
Conversation
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Can anybody please check what's wrong in my code |
Codecov Report
@@ Coverage Diff @@
## main #10633 +/- ##
=======================================
Coverage 81.48% 81.48%
=======================================
Files 98 98
Lines 5996 5996
=======================================
Hits 4886 4886
Misses 1110 1110
|
|
Hi @jywarren , |
|
And just to be clear, i believe there's nothing at all wrong with your contribution! It's just an upstream issue. Thanks! ⭐ |
|
/rebase |
080f19b to
c03cbdc
Compare
|
Code Climate has analyzed commit c03cbdc and detected 0 issues on this pull request. View more on Code Climate. |
|
Hi @jywarren unknowingly I closed this "pull request" so, sorry for that. |
|
No worries, i just approved and it'll run again now. |
|
@jywarren Thank you very much. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 https://code.publiclab.org Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
|
Great, it resolved! Excellent work, and thank you so much!! |
Changed First Timers Issue Template url in CONRIBUTION,
Changed the location of "Templets for opening a issue" in README.
Fixes #10625
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below