Skip to content

Comments

Fix: updated First timers issue template url and changed the location of "templet for opening a issue".#10633

Merged
jywarren merged 1 commit intopubliclab:mainfrom
AshSmah:issue
Jan 12, 2022
Merged

Fix: updated First timers issue template url and changed the location of "templet for opening a issue".#10633
jywarren merged 1 commit intopubliclab:mainfrom
AshSmah:issue

Conversation

@AshSmah
Copy link
Contributor

@AshSmah AshSmah commented Jan 10, 2022

Changed First Timers Issue Template url in CONRIBUTION,
Changed the location of "Templets for opening a issue" in README.

Fixes #10625

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Jan 10, 2022

@AshSmah AshSmah changed the title Fix: updated First timers issue template url and changed the location templet for opening a issue. Fix: updated First timers issue template url and changed the location of "templet for opening a issue". Jan 10, 2022
Copy link
Contributor

@RuthNjeri RuthNjeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @AshSmah

PR can be merged once all tests pass!

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/4880096715/artifacts/139724303

@AshSmah
Copy link
Contributor Author

AshSmah commented Jan 10, 2022

Can anybody please check what's wrong in my code

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!!!

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #10633 (080f19b) into main (adca325) will not change coverage.
The diff coverage is n/a.

❗ Current head 080f19b differs from pull request most recent head c03cbdc. Consider uploading reports for the commit c03cbdc to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10633   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files          98       98           
  Lines        5996     5996           
=======================================
  Hits         4886     4886           
  Misses       1110     1110           
Impacted Files Coverage Δ
app/models/tag.rb 93.23% <0.00%> (ø)

@AshSmah
Copy link
Contributor Author

AshSmah commented Jan 11, 2022

Hi @jywarren ,
Could you please tell me what to do?.

@jywarren
Copy link
Member

Hi @AshSmah i'm so sorry - some completely unrelated thing happened and affected ALL pull requests in our repository. Please don't worry for a bit, i'm troubleshooting it. I'm sorry to stress you out! I believe it should be OK in a little bit... now that #10640 is completed, which had the fix.

@jywarren
Copy link
Member

And just to be clear, i believe there's nothing at all wrong with your contribution! It's just an upstream issue. Thanks! ⭐

@jywarren
Copy link
Member

/rebase

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit c03cbdc and detected 0 issues on this pull request.

View more on Code Climate.

@AshSmah AshSmah closed this Jan 12, 2022
@AshSmah AshSmah reopened this Jan 12, 2022
@AshSmah
Copy link
Contributor Author

AshSmah commented Jan 12, 2022

Hi @jywarren unknowingly I closed this "pull request" so, sorry for that.

@jywarren
Copy link
Member

No worries, i just approved and it'll run again now.

@AshSmah
Copy link
Contributor Author

AshSmah commented Jan 12, 2022

@jywarren Thank you very much.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/4904513307/artifacts/141025752

@jywarren jywarren merged commit 7fb2247 into publiclab:main Jan 12, 2022
@welcome
Copy link

welcome bot commented Jan 12, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Great, it resolved! Excellent work, and thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update First-timers issue template link in markdown files

3 participants