updated rubocop_shopify_style_guide and related files#10877
updated rubocop_shopify_style_guide and related files#10877jywarren merged 7 commits intopubliclab:mainfrom
Conversation
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
@jywarren How can I run codeclimate on my local system? |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Gemfile
Outdated
| gem "webmock", "~> 3.14" | ||
| gem 'rubocop-rails', require: false | ||
| gem 'rubocop-performance', require: false | ||
| gem 'rubocop-rspec', require: false |
There was a problem hiding this comment.
This looks really good @kunmi02. I was able to run rubocop in my local env. Why do we need these additional gems? Also, I don't think we need the rubocop-rspec gem since we don't use RSpec as our test suite.
There was a problem hiding this comment.
Most of the outdated commands on the rubocop file are now wrapped in the gems I added. For the rubocop-rspec, I have removed it from the gemfile.
|
Code Climate has analyzed commit ed4d569 and detected 45 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
@TildaDares Please review again |
jywarren
left a comment
There was a problem hiding this comment.
Looks great. Thank you very much, and thanks @TildaDares for the close look!
Added new gems rubocop-rails, rubocop-performanc and rubocop rspec on the gem file. I also removed some old rubocop command in the rubocop shopify style guide and added new ones to it. Also modifiied the rubocop.yml file and the rubocop_todo.yml file
Fixes #10868 and #8646
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below