Skip to content

Comments

updated rubocop_shopify_style_guide and related files#10877

Merged
jywarren merged 7 commits intopubliclab:mainfrom
kunmi02:update-rubocop-style-guide
Apr 5, 2022
Merged

updated rubocop_shopify_style_guide and related files#10877
jywarren merged 7 commits intopubliclab:mainfrom
kunmi02:update-rubocop-style-guide

Conversation

@kunmi02
Copy link
Contributor

@kunmi02 kunmi02 commented Mar 30, 2022

Added new gems rubocop-rails, rubocop-performanc and rubocop rspec on the gem file. I also removed some old rubocop command in the rubocop shopify style guide and added new ones to it. Also modifiied the rubocop.yml file and the rubocop_todo.yml file
Fixes #10868 and #8646

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Mar 30, 2022

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5867897391/artifacts/197934836

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5868221354/artifacts/197952319

@kunmi02
Copy link
Contributor Author

kunmi02 commented Mar 30, 2022

@jywarren How can I run codeclimate on my local system?
cc @TildaDares

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5868434999/artifacts/197963235

Gemfile Outdated
gem "webmock", "~> 3.14"
gem 'rubocop-rails', require: false
gem 'rubocop-performance', require: false
gem 'rubocop-rspec', require: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good @kunmi02. I was able to run rubocop in my local env. Why do we need these additional gems? Also, I don't think we need the rubocop-rspec gem since we don't use RSpec as our test suite.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the outdated commands on the rubocop file are now wrapped in the gems I added. For the rubocop-rspec, I have removed it from the gemfile.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit ed4d569 and detected 45 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 45

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5920227040/artifacts/202277007

@kunmi02
Copy link
Contributor Author

kunmi02 commented Apr 4, 2022

@TildaDares Please review again

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @kunmi02.

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you very much, and thanks @TildaDares for the close look!

@jywarren jywarren merged commit c3a58e7 into publiclab:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

obsolete configuration found in the rubocop style guide

3 participants