-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openssl added for https #2745
Openssl added for https #2745
Conversation
27ff107
to
649fc68
Compare
I think this is OK and if it does not interrupt the existing SSL config on production (@icarito can tell us it's ok or not?) then we should be fine and I"m OK merging this in. I think we're still seeing some issues with the travis containers so that may hold us up a bit first. Thanks! |
OK great to hear that. Please check this twice on production before merging @icarito. Also, we need to notify the existing developers about the command to launch the passenger server is changed. |
@jywarren I tried to understand the Travis issues but was not able to. Any help is greatly appreciated. |
Retriggering! Now it's solved... |
Generated by 🚫 Danger |
Gemfile
Outdated
@@ -130,3 +130,4 @@ gem 'omniauth-github', '~> 1.1', '>= 1.1.2' | |||
gem 'activerecord-tableless' | |||
gem 'figaro' | |||
gem 'sanitize' | |||
gem 'openssl', '~> 2.0.0.beta.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this into the development
gems only, since we won't be using this in production? Thanks!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes for sure.
And if you could change the docs -- the README or corresponding file -- but just say that |
@jywarren for the non-secure connection (HTTP) we can use port number |
a6495d0
to
598d22d
Compare
Ah, i think this was affected by the previous issue of Dockerfile config. If you rebase it over the latest master branch, it should pass! |
@jywarren can we merge this? |
Perfect, thank you!!!! 👍 👍 👍 |
* Openssl added for https * Changed Installation guidelines * localhost.key added * Openssl moved to development and test group * Updated readme * changed config settings * Updated readme * patches * CodeClimate Error Fixed
@jywarren new Facebook settings allow the login through the localhost only if we are using https. I found that we can provide the https in development by creating the certificates by openssl gem and running the
passenger start --ssl --ssl-certificate localhost.crt --ssl-certificate-key localhost.key --ssl-port 3000
command instead of passenger start.This blog might be helpful. https://www.devmynd.com/blog/rails-local-development-https-using-self-signed-ssl-certificate/
Also, I have changed the installation guidelines a little. Check it out.