Fix "Cannot read property 'slice' of undefined" bug with min/max dates #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug in
makeDateValues()
that occurs if you specified a min and/or max date, but have set the value of the control tonull
or an empty value. It was caused by some typos.You can reproduce this issue by set minDate (and/or maxDate), clicking to change the date, and then deleting the value.
Motivation and Context
This fixes a bug that causes a runtime error that prevents
makeDateValues()
from fully running. That has other implications, including theonChange
handler not running.In the browser console, you'll get the error message
Uncaught TypeError: Cannot read property 'slice' of undefined
, as reported in issue #134How Has This Been Tested?
Only manually.
Types of changes
Checklist: