-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add manylinux armv7l #2052
Conversation
Cool! would it make sense to call the ubuntu-based image something different than |
That's why the only platform that allows manylinux_2_31 is armv7l in this PR. This is mentioned in the docs also but maybe it should be explained a bit more in there ? mostly, that you need to use The PoC repo builds all images as a multiplatform images but if the image gets integrated in the pypa/manylinux repo, only armv7l will be added to avoid as much as possible any confusion and relive the whole manylinux_2_24 episode
I won't rename the images themselves, at least before any move in pypa/manylinux and probably not at that time either. |
0de28aa
to
93b5a99
Compare
Agree, since it's only one arch, as long as it's communicated well, it should be fine. |
Thanks for the reply @mayeut - entirely up to you. Good to hear that it'd only be available on armv7l if included in the mainline release set. My feedback is just that because the manylinux naming scheme is based on the glibc version, the name implies that 'this is the manylinux image for glibc 2.31', which I don't think you're trying to communicate, I think we'd like it to say 'this is an unusual manylinux image for armv7l which is on glibc 2.31'. Adding the word 'ubuntu' somewhere might help people understand that. The other advantage would be alleviating the need to remember that specifically manylinux_2_31 is a unusual image compared to the others - that's something I'm bound to forget. Having said all that, if you'd prefer to keep it as-is, that's okay with me. I don't think it'd be a big problem if |
535b57e
to
f5f185c
Compare
Thanks for your feedback @joerick.
I don't quite understand that first part: from the manylinux repo readme, each description is roughly the same and I think it's conveying the right message:
If you do feel there are some clarification needed there, please do open a PR. I'm probably too close to the subject and thus lack perspective on how to enhance this documentation.
I don't really want to convey the "unusual" message here. It is (& most likely will stay) "usual" for armv7l. Edit: added a README on https://github.com/mayeut/manylinux-ubuntu if this helps on the doc side. |
c87a04b
to
b1c1204
Compare
b1c1204
to
acf3099
Compare
This adds manylinux armv7l using an experimental ubuntu based manylinux_2_31 image using deadsnakes python packages.
An official image based might become available at some point but not before aarch64 runner support on GHA.
The experimental image should be able to generate wheels compatible with all armv7l Raspberry Pi currently supported by piwheels.org.
While the gcc toolchain is not as recent as one can get on RHEL derivatives, debian/ubuntu is the only possible path forward for
armv7l
.