Add pre-commit hooks for autofixing trailing whitespace #15237
Conversation
This comment has been minimized.
This comment has been minimized.
|
(The first commit is the changes to our config files; the second commit shows the kinds of changes that these new hooks will push to PRs in CI.) |
| @@ -9,6 +9,7 @@ flake8-noqa==1.3.1; python_version >= "3.8" # must match version in .pre-co | |||
| isort[colors]==5.12.0; python_version >= "3.8" # must match version in .pre-commit-config.yaml | |||
| lxml>=4.9.1; (python_version<'3.11' or sys_platform!='win32') and python_version<'3.12' | |||
| pre-commit | |||
| pre-commit-hooks==4.4.0 | |||
There was a problem hiding this comment.
I guess we can add this for consistency, but I don't think people will use pre-commit-hooks as a standalone package. I didn't even know it could be run standalone until now.
There was a problem hiding this comment.
Yeah, it does seem unlikely that people are going to be manually running trailing-whitespace mypy/semanal.py locally (for example). And it's true that pre-commit requirements don't need to be pre-installed for pre-commit to work locally. So, I'm happy to remove this -- but curious to hear what others think, as well.
| @@ -6,7 +6,7 @@ def get_method_signature_hook(self, fullname): | |||
| if 'FullyQualifiedTest' in fullname: | |||
There was a problem hiding this comment.
Maybe we should just run Black on this?
There was a problem hiding this comment.
Black makes quite a few change if I apply this diff to our pyproject.toml file:
diff --git a/pyproject.toml b/pyproject.toml
index 3d100dff5..a06acccf2 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -23,8 +23,6 @@ target-version = ["py37", "py38", "py39", "py310", "py311"]
skip-magic-trailing-comma = true
force-exclude = '''
^/mypy/typeshed|
-^/mypyc/test-data|
-^/test-data
'''
[tool.isort]I'm happy to consider doing that, but maybe that should be left for another PR? Feels like running these new hooks on our test-data/ files and running black on our test-data/ files aren't really mutually exclusive.
mypyc/external/googletest/include/gtest/internal/gtest-internal.h
Outdated
Show resolved
Hide resolved
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
pre-commit is failing on `master`: https://github.com/python/mypy/actions/runs/4970566646/jobs/8894519893 The cause was a merge race between #15234 and #15237
No description provided.