[1/N] Add -Wdeprecated and related fixes

[cyyever]

This PR adds -Wdeprecated to CMake warnings and fixes related issues.
cc @EikanWang @jgong5 @ezyang @colesbury @Skylion007

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108626

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 63a111e with merge base 2c1554a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[pytorchmergebot]

Successfully rebased wdeprecated onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout wdeprecated && git pull --rebase)

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[cyyever]

@pytorchbot label ciflow/binaries

[pytorchmergebot]

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

[cyyever]

@pytorchmergebot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[clee2000]

@pytorchbot revert -m "I'm getting errors internally that look like the below on x86_64-apple-ios-simulator with clang 16 D49440218" -c ghfirst

xplat/caffe2/c10/util/Optional.h:740:12: error: implicit conversion turns string literal into bool: 'const char[14]' to 'bool' [-Werror,-Wstring-conversion]
    return TR2_OPTIONAL_ASSERTED_EXPRESSION(initialized(), dataptr());
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                 ^

[pytorchmergebot]

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

[pytorchmergebot]

@cyyever your PR has been successfully reverted.

[cyyever]

@clee2000 Should we put x86_64-apple-ios-simulator tests in CI?

implicit conversion turns string literal into bool: 'const char[14]' to 'bool' 

May I obtain the string literal because there is no string involved in c10/util/Optional.h

[clee2000]

I'm not sure what the string literal is tbh

@ezyang says

TR2_OPTIONAL_HOST_CONSTEXPR T const& operator*() const& {
    return TR2_OPTIONAL_ASSERTED_EXPRESSION(initialized(), contained_val());
  }

is the critical line.

This is what the rest of the error looks like, I've changed some things since I'm not sure what I'm actually allowed to post

In file included from ***
In file included from caffe2/core/operator.h:21:
In file included from caffe2/core/blob.h:14:
In file included from caffe2/core/tensor.h:5:
In file included from caffe2/core/storage.h:23:
In file included from c10/core/Storage.h:3:
In file included from c10/core/StorageImpl.h:4:
In file included from c10/core/SymInt.h:3:
In file included from c10/core/SymBool.h:3:
In file included from c10/core/SymNodeImpl.h:6:
c10/util/Optional.h:749:12: error: implicit conversion turns string literal into bool: 'const char[14]' to 'bool' [-Werror,-Wstring-conversion]
    return TR2_OPTIONAL_ASSERTED_EXPRESSION(initialized(), contained_val());
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
c10/util/Optional.h:87:37: note: expanded from macro 'TR2_OPTIONAL_ASSERTED_EXPRESSION'
  ((CHECK) ? (EXPR) : ([] { assert(!#CHECK); }(), (EXPR)))
                                   ~^~~~~~
<scratch space>:85:1: note: expanded from here
"initialized()"
^~~~~~~~~~~~~~~
***/third-party/toolchains/xcode/14.1.0/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)
                        ^
c10/util/Optional.h:782:20: note: in instantiation of member function 'c10::optional<bool>::operator*' requested here
    return *this ? **this : detail_::convert<T>(constexpr_forward<V>(v));
                   ^
c10/core/TensorOptions.h:42:24: note: in instantiation of function template specialization 'c10::optional<bool>::value_or<bool>' requested here
  return pinned_memory.value_or(false);
                       ^
6 errors generated.
    When running <c++ preprocess_and_compile>.
    When building rule ***
Not all rules succeeded.

Side note do you have slack?

I thought the ios simulator tests would have been enough but I guess not? @malfet

cc @ezyang

[cyyever]

@clee2000 Thank you so much,very helpful track back information. I will try to fix it tomorrow

[malfet]

@clee2000 our iOS build are running using different version of xcode, this is why it was not caught