Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable #109869
Conversation
…VTs instead of ConstantVariable [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109869
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 804f719 with merge base 691f8ca ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
… requisite VTs instead of ConstantVariable" cc penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…VTs instead of ConstantVariable ghstack-source-id: a389af0b267967429a71c4c5b559c2895d67d012 Pull Request resolved: #109869 [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable
|
Can you do the ConstantVariable.create change on its own? I'll stamp it. (BTW, if you don't want to update the call sites, you can technically make the constructor do what you want by defining |
… requisite VTs instead of ConstantVariable" cc penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…site VTs instead of ConstantVariable" cc penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
no |
…site VTs instead of ConstantVariable" cc penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…VTs instead of ConstantVariable ghstack-source-id: 3f6b203548f29c1f4b07b1941b4a499348772768 Pull Request resolved: #109869 [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…e VTs instead of ConstantVariable (#109869)" This reverts commit 06aa696. Reverted #109869 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but the failed test looks legit as it is also failing in trunk https://hud.pytorch.org/pytorch/pytorch/commit/06aa6966a88586d34e6470cc2149121d17971056 ([comment](#109869 (comment)))
…site VTs instead of ConstantVariable" cc penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…site VTs instead of ConstantVariable" cc penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
…VTs instead of ConstantVariable ghstack-source-id: 13571a067511cb802d35f4e5ce003cc56bf9692b Pull Request resolved: #109869 [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable more test more test
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
torch/_inductor/utils.py
Outdated
| # getattr(torch.ops, "torchvision", None), "roi_align" | ||
| # ) | ||
| # except ImportError: | ||
| return False |
There was a problem hiding this comment.
Staged the wrong file?
…site VTs instead of ConstantVariable" cc penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
…VTs instead of ConstantVariable ghstack-source-id: 662add5b03d3167a515cba3e96c154455aaba1bd Pull Request resolved: #109869 [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable [WIP] Better invariants - always route list/tuple to their requisite VTs instead of ConstantVariable more test more test more test
|
@pytorchbot merge |
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
|
The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge |
|
The CI fiasco on this pr has been vaguely awful |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
cc @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov