Reland "Update AOTAutograd to use FunctionalTensorMode instead of C++ functionalization (#106406)" #109906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109906
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e349469 with merge base d0c8e82 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
approved these changes
Sep 23, 2023
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Breaks internal tests" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@bdhirsh your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Sep 26, 2023
…d of C++ functionalization (#106406)" (#109906)" This reverts commit d0fe8fa. Reverted #109906 on behalf of https://github.com/atalman due to Breaks internal tests ([comment](#109906 (comment)))
bdhirsh
added a commit
that referenced
this pull request
Sep 26, 2023
bdhirsh
added a commit
that referenced
this pull request
Sep 29, 2023
bdhirsh
added a commit
that referenced
this pull request
Sep 29, 2023
… use FunctionalTensorMode instead of C++ functionalization (#106406)" (#109906)"" The first reland broke internal (failing diff: D49617462). The major error looks like it's because there's an internal-only higher order op that needs a new functionalization rule. I'm going to land an internal diff for that and confirm tests pass before relanding this PR. This reverts commit 1b90f07. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Sep 29, 2023
…ensorMode instead of C++ functionalization (#106406)" (#109906)"" The first reland broke internal (failing diff: D49617462). The major error looks like it's because there's an internal-only higher order op that needs a new functionalization rule. I'm going to land an internal diff for that and confirm tests pass before relanding this PR. This reverts commit 1b90f07. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Oct 3, 2023
… use FunctionalTensorMode instead of C++ functionalization (#106406)" (#109906)"" The first reland broke internal (failing diff: D49617462). The major error looks like it's because there's an internal-only higher order op that needs a new functionalization rule. I'm going to land an internal diff for that and confirm tests pass before relanding this PR. Also confirmed that the issue from #110121 is fixed, and added a test. This reverts commit 1b90f07. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Oct 3, 2023
bdhirsh
added a commit
that referenced
this pull request
Oct 3, 2023
…ensorMode instead of C++ functionalization (#106406)" (#109906)"" The first reland broke internal (failing diff: D49617462). The major error looks like it's because there's an internal-only higher order op that needs a new functionalization rule. I'm going to land an internal diff for that and confirm tests pass before relanding this PR. Also confirmed that the issue from #110121 is fixed, and added a test. This reverts commit 1b90f07. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 3, 2023
…nstead of C++ functionalization (#106406)" (#109906)" (#110079) The first reland broke internal (failing diff: D49617462). The major error looks like it's because there's an internal-only higher order op that needs a new functionalization rule. I'm going to land an internal diff for that and confirm tests pass before relanding this PR. Also confirmed that the issue from #110121 is fixed, and added a test. This reverts commit 1b90f07. Pull Request resolved: #110079 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this is fixed but I'll run inductor and trunk CI. The failing test in trunk previously was that the selective activation checkpointing code that landed recently assumes that it can detect whether or not AOTAutograd is running by seeing if the inputs to SAC are C++
FunctionalTensorWrappersStack from ghstack (oldest at bottom):
previous land broke some inductor trunk tests
This reverts commit 629a628.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov