[PyTorch][AMD] fix hipify_python #76720
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This PR fixes an issue in hipify_python introduced by pytorch#76141. pytorch#76141 made all the `includes` paths "absolute", but this was not done for `args.extra_include_dir`; `new_dir`, which is a relative path, is directly added to `includes`. This PR fixes it by passing the absolute path (`abs_new_dir`). Test Plan: CI Differential Revision: D36089556 fbshipit-source-id: eb9c68b8d9a99dd5bdcf621ecdd6f18470f4321b
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c9dfd24 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D36089556 |
|
cc @rraminen, @jeffdaily I'd appreciate your feedback. |
jeffdaily
approved these changes
May 3, 2022
osalpekar
approved these changes
May 3, 2022
|
Thanks for your reviews, @jeffdaily, @albanD, abd @osalpekar. I will merge it. |
|
LGTM |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 3, 2022
Summary: Pull Request resolved: #76720 This PR fixes an issue in hipify_python introduced by #76141. #76141 made all the `includes` paths "absolute", but this was not done for `args.extra_include_dir`; `new_dir`, which is a relative path, is directly added to `includes`. This PR fixes it by passing the absolute path (`abs_new_dir`). Test Plan: CI Reviewed By: albanD Differential Revision: D36089556 fbshipit-source-id: 1607075a4cb13696c1b25923f56b08a8cb3c6578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes an issue in hipify_python introduced by #76141.
#76141 made all the
includespaths "absolute", but this was not done forargs.extra_include_dir;new_dir, which is a relative path, is directly added toincludes. This PR fixes it by passing the absolute path (abs_new_dir).Test Plan: CI
Differential Revision: D36089556