Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch17: jupyter notebooks for GAN models #21

Merged
merged 6 commits into from
Nov 2, 2019
Merged

Ch17: jupyter notebooks for GAN models #21

merged 6 commits into from
Nov 2, 2019

Conversation

vmirly
Copy link
Collaborator

@vmirly vmirly commented Oct 27, 2019

No description provided.

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@rasbt
Copy link
Owner

rasbt commented Oct 27, 2019

Sth isn't right with your PRs ... You have Ch 15 and the same commits in all of them. Can you fix that?

@rasbt
Copy link
Owner

rasbt commented Oct 28, 2019

  • can you rename to ch17_part1.ipynb and ch17_part2.ipynb for consistency? We have that in Ch13 too

  • seem like the issue with ch15 is fixed, but this one still has ch16 extra. Pls remove ch16 from the commit

@vmirly vmirly changed the base branch from master to ch16 November 2, 2019 16:01
@vmirly vmirly merged commit 6522245 into ch16 Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants