match chapter sections #6
Conversation
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
|
@vmirly pls take a look at the changes and then merge |
| @@ -11,19 +11,69 @@ | |||
| "Code License: [MIT License](https://github.com/rasbt/python-machine-learning-book-3rd-edition/blob/master/LICENSE.txt)" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
In the last cell with headline: Splitting a dataset using tfds.Split, there is a bug in tfds.Split, so we may want to either remove it completely or add the following comment:
##--------------------------- Attention -----------------------------##
## Note: currently, tfds.Split ahs a bug ##
## splitting [2, 1] is expected to result in 100 train and 50 test ##
## but instead, it results in 116 train and 34 test examples ##
##-------------------------------------------------------------------##
There was a problem hiding this comment.
Oh good that you caught that. We can keep it with that warning -- and we can then revisit this when Tf 2.0.1 comes out. In the meantime, can you add a further comment about this. I edited the one you had above and also fixed some typos. Please insert the one below into the notebook:
##--------------------------- Attention -----------------------------##
## Note: currently, tfds.Split has a bug in TF 2.0.0 ##
## I.e., splitting [2, 1] is expected to result in 100 train and 50 test examples ##
## but instead, it results in 116 train and 34 test examples ##
##-------------------------------------------------------------------##
No description provided.