Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the notebook for Ch15 #9

Merged
merged 4 commits into from
Oct 20, 2019
Merged

Added the notebook for Ch15 #9

merged 4 commits into from
Oct 20, 2019

Conversation

vmirly
Copy link
Collaborator

@vmirly vmirly commented Oct 20, 2019

Notebook containing the codes for Ch15 (CNNs)

Chapter headings are inserted to the notebook

Verified

This commit was signed with the committer’s verified signature.
re-taro Rintaro Itokawa
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@vmirly vmirly requested a review from rasbt October 20, 2019 17:51
@review-notebook-app
Copy link

review-notebook-app bot commented Oct 20, 2019

View / edit / reply to this conversation on ReviewNB (backstory for this conversation format).

rasbt commented on 2019-10-20T19:40:19Z
----------------------------------------------------------------

Could you add the header to the notebook that we have in other notebooks. I.e., see

E.g., see the top of https://github.com/rasbt/python-machine-learning-book-3rd-edition/blob/master/ch14/ch14-notebook.ipynb


vmirly commented on 2019-10-20T20:13:46Z
----------------------------------------------------------------

Sure, I added the header

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 20, 2019

View / edit / reply to this conversation on ReviewNB (backstory for this conversation format).

rasbt commented on 2019-10-20T19:40:20Z
----------------------------------------------------------------

Can you add the footer that we have in other notebooks, e.g., see https://github.com/rasbt/python-machine-learning-book-3rd-edition/blob/master/ch14/ch14-notebook.ipynb

I am talking about

...

Summary

...

----

Readers may ignore the next cell.

! python ../.convert_notebook_to_script.py --input ch15.ipynb --output ch15.py


vmirly commented on 2019-10-20T20:13:57Z
----------------------------------------------------------------

Sure

@vmirly vmirly merged commit a0fcd2d into master Oct 20, 2019
@vmirly vmirly deleted the ch15 branch October 20, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant