Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Reconciliation page #76

Merged
merged 6 commits into from
Mar 13, 2019
Merged

Translate Reconciliation page #76

merged 6 commits into from
Mar 13, 2019

Conversation

linsolas
Copy link
Contributor

Hello,

Voilà ma traduction de la page Reconciliation.

Bonne lecture !

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@netlify
Copy link

netlify bot commented Feb 28, 2019

@Nab69 Nab69 added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 1, 2019
@JeremiePat JeremiePat self-requested a review March 8, 2019 10:16
@JeremiePat JeremiePat added the Reviewing Un mainteneur qualifié est en train de composer la revue de code label Mar 8, 2019
Copy link
Collaborator

@JeremiePat JeremiePat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @linsolas

Quelques petite bricoles à changer mais sinon c'était super claire :)

@JeremiePat JeremiePat added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Mar 8, 2019
@tdd tdd self-assigned this Mar 8, 2019
JeremiePat and others added 2 commits March 8, 2019 23:12

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: linsolas <linsolas@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tdd tdd added Reviewing Un mainteneur qualifié est en train de composer la revue de code and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Mar 9, 2019
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @linsolas !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

Comme d'hab', peu de retouches structurelles et pas mal de bons choix de phrasé, j'ai les correctifs habituels (cela -> ça, etc.), des harmonisations de trads et des clarifications diverses.

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de cliquer le bouton d'ajout au lot de modifs à committer, et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

@tdd tdd removed the Reviewing Un mainteneur qualifié est en train de composer la revue de code label Mar 10, 2019
@tdd
Copy link
Collaborator

tdd commented Mar 12, 2019

@linsolas t'aurais pas oublié que j'ai fini ma revue y'a 2j, toi ? 😛

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: linsolas <linsolas@gmail.com>
@linsolas
Copy link
Contributor Author

Effectivement ! Voilà chose faite.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tdd tdd merged commit d3521eb into reactjs:master Mar 13, 2019
@linsolas linsolas deleted the patch-1 branch March 14, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants