feat: support setting secrets for renovate #52
Conversation
|
The tests expect that I bump the version of the chart but the version seems to be bounded to the version of renovate. What should I do? |
|
@gmariotti Sorry I've missed this PR. I'll find some time today to review it. We decided to pin the helm chart version to the renovate version to make auto updates easier. I think we should be able to add a build version, and still stay compliant with semver. Something like |
| release: {{ .Release.Name }} | ||
| heritage: {{ .Release.Service }} | ||
| type: Opaque | ||
| data: |
There was a problem hiding this comment.
I would simplify this to stringData and drop the b64enc
There was a problem hiding this comment.
I will fix it, thanks 🙏
There was a problem hiding this comment.
I didn't find any stringData function, could you point me to it?
|
What about documentation? Is there anything I need to do? |
|
Yeah, can you add an example to the And don't worry about merging, I'll figure it out 😅 |
There was a problem hiding this comment.
@gmariotti Can you please rebase the pr or merge master into it
|
@viceice @JamieMagee rebased with master and addressed some of the comments, but I'm still having a problem with the version number (probably because of the commit prefix used), any suggestion? |
|
Should be released with next renovate update |
|
v23 on the way: renovatebot/docker-renovate-full#59 |
Hi, I created this PR to make it possible to use k8s/Secret to pass sensitive data to Renovate. I'm no Helm expert, I probably missed something for sure 😅