Fix rook install #1490
Merged
Fix rook install #1490
+99
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
commented
Apr 18, 2021
| @@ -526,6 +526,7 @@ build/packages/k-3-s/%/rhel-8: | |||
| build/templates: build/templates/install.tmpl build/templates/join.tmpl build/templates/upgrade.tmpl build/templates/tasks.tmpl | |||
|
|
|||
| build/bin: build/bin/kurl | |||
| rm -rf kurl_util/bin | |||
There was a problem hiding this comment.
Rebuild kurl_utils on make watchrsync
emosbaugh
commented
Apr 18, 2021
| @@ -153,6 +153,17 @@ function rook_cluster_deploy_upgrade() { | |||
| return 0 | |||
| fi | |||
|
|
|||
| echo "Awaiting rook-ceph operator" | |||
|
|
|||
| if ! spinner_until 600 rook_version_deployed ; then | |||
There was a problem hiding this comment.
This code only needs to run on upgrades. It is currently blocking new rook installations.
emosbaugh
commented
Apr 18, 2021
| @@ -211,25 +211,37 @@ function rook_ceph_healthy() { | |||
|
|
|||
| # rook_version_deployed check that there is only one rook-version reported across the cluster | |||
| function rook_version_deployed() { | |||
| # wait for our version to start reporting | |||
| if ! kubectl -n rook-ceph get deployment -l rook_cluster=rook-ceph -o jsonpath='{range .items[*]}{"rook-version="}{.metadata.labels.rook-version}{"\n"}{end}' | grep -q "${ROOK_VERSION}" ; then | |||
There was a problem hiding this comment.
make sure that the version is reporting before checking if multiple versions are reporting to prevent race condition.
areed
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rook new installs on 1.4.9 and 1.5.9 are broken as it polls forever for the cluster before deploying the cluster.
Fix race condition on upgrades that causes the cluster to be upgraded before it is ready.