Go dependency updates #1632
Merged
Go dependency updates #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
reviewed
May 24, 2021
pkg/preflight/builtin_test.go
Outdated
| @@ -10,7 +10,7 @@ import ( | |||
| "github.com/replicatedhq/kurl/pkg/installer" | |||
| "github.com/stretchr/testify/assert" | |||
| "github.com/stretchr/testify/require" | |||
| yaml "gopkg.in/yaml.v3" | |||
| yaml "gopkg.in/yaml.v2" | |||
There was a problem hiding this comment.
ooh because it was the only v3 usage, ok
There was a problem hiding this comment.
had to add it back anyway. unmarshal failed
laverya
approved these changes
May 24, 2021
|
Damn, builds are failing. I ran it locally and it worked. Ill have to see what is the difference. |
emosbaugh
commented
May 24, 2021
| @@ -16,7 +16,7 @@ import ( | |||
| kurlscheme "github.com/replicatedhq/kurl/kurlkinds/client/kurlclientset/scheme" | |||
| kurlv1beta1 "github.com/replicatedhq/kurl/kurlkinds/pkg/apis/cluster/v1beta1" | |||
| kurlversion "github.com/replicatedhq/kurl/pkg/version" | |||
| "gopkg.in/yaml.v1" | |||
There was a problem hiding this comment.
@areed is there any reason this is using v1?
laverya
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.