Run testgrid after deploy. Require instances and os specs from the cli #1796
+1,575
−1,403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
reviewed
Jun 28, 2021
| @@ -106,7 +106,7 @@ type Kubernetes struct { | |||
| } | |||
|
|
|||
| type Kurl struct { | |||
| AdditionalNoProxyAddresses []string `json:"additionalNoProxyAddresses,omitempty" yaml:"proxyAddress,omitempty"` | |||
There was a problem hiding this comment.
Isn't that a bug. It's the wrong yaml tag. Or am I misunderstanding your comment?
laverya
reviewed
Jun 28, 2021
testgrid/specs/latest.yaml
Outdated
| @@ -0,0 +1,20 @@ | |||
| - name: "" | |||
There was a problem hiding this comment.
can we also include the spec for longhorn? https://kurl.sh/longhorn
laverya
reviewed
Jun 28, 2021
| @@ -34,6 +34,9 @@ func generateAllAddOns() ([]kurlv1beta1.InstallerSpec, error) { | |||
| return installerSpecs, nil | |||
| } | |||
|
|
|||
| // hack | |||
| var previouslyGeneratedNames = []string{} | |||
There was a problem hiding this comment.
what's this used for? (I realize it's not new)
There was a problem hiding this comment.
i have no idea. i moved it closer to where its referenced
laverya
approved these changes
Jun 28, 2021
91cf1cb to
bc40bfd
Compare
laverya
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.