New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kURL allow custom vendor host preflight checks #2133

Merged

kwsorensen merged 23 commits into master from kylesorensen/sc-37568/custom-host-preflights-can-be-declared-in

Sep 24, 2021

Contributor

kwsorensen commented Sep 20, 2021

No description provided.

kwsorensen and others added 13 commits

September 20, 2021 22:33


          initial scaffolding done

b44c42c


          schema change for kurl installer

3a2df1c


          updated changes


          updated code changes

8a82a56


          Fix schema gen

d1621b3


          update test kurl spec

b1763ce


          hostPreflight example

fd4a9a6


          update code

c1e76a2


          fixed broken tgrun

d8ddc3e


          Extract preflight spec from installer spec

aa3b840


          delete not needed files

f393c07


          cleanup

5cce6eb


          functionality there

f1e0eef

kwsorensen commented

View reviewed changes

CONTRIBUTING.md Show resolved Hide resolved


          ready for pr

c7cd072

kwsorensen requested review from murphybytes and jala-dx

September 23, 2021 19:41

murphybytes reviewed

View reviewed changes

kurl_util/cmd/vendorflights/main.go Show resolved Hide resolved

murphybytes reviewed

View reviewed changes

kurl_util/cmd/vendorflights/main_test.go Outdated Show resolved Hide resolved

murphybytes reviewed

View reviewed changes

scripts/common/preflights.sh Outdated Show resolved Hide resolved

murphybytes reviewed

View reviewed changes

scripts/common/preflights.sh Outdated Show resolved Hide resolved

murphybytes reviewed

View reviewed changes

scripts/common/preflights.sh Outdated Show resolved Hide resolved

murphybytes reviewed

View reviewed changes

web/src/installers/index.ts Show resolved Hide resolved

murphybytes suggested changes

View reviewed changes

Contributor

murphybytes left a comment

One of your bash variables is named incorrectly, and a couple other nits

kwsorensen added 3 commits

September 23, 2021 21:45


          updated based on pr feedback

899d2d4


          update test

924c51e


          updated to check for apiversion

0c3e467

kwsorensen requested a review from murphybytes

September 24, 2021 14:49

jala-dx approved these changes

View reviewed changes

jala-dx requested a review from areed

September 24, 2021 14:55

murphybytes reviewed

View reviewed changes

kurl_util/cmd/vendorflights/main_test.go Show resolved Hide resolved

murphybytes previously requested changes

View reviewed changes

Contributor

murphybytes left a comment

This looks great! Please provide a README.md in kurl_util/cmd/vendorflights that describes how to use the vendorflights program and what it's for and then I'll approve. I'd like us to get in the habit of providing README's when we author new go programs to make it easier to maintain things going forward.


          added simple readme

b574815

kwsorensen requested a review from murphybytes

September 24, 2021 16:14

kwsorensen dismissed murphybytes’s stale review

September 24, 2021 16:22

README added

murphybytes approved these changes

View reviewed changes

emosbaugh reviewed

View reviewed changes

kurlkinds/pkg/apis/cluster/v1beta1/installer_types.go Outdated Show resolved Hide resolved

kurlkinds/Makefile Show resolved Hide resolved

kwsorensen added 5 commits

September 24, 2021 17:07


          merged with master

1de3129


          update yaml

16b6e51


          update go fmt

35c4fb9


          mod tidy

683987d


          mod tidy and adding host_prefights to yamltobash

a05c821

emosbaugh approved these changes

View reviewed changes

kwsorensen merged commit efb1766 into master

kwsorensen deleted the kylesorensen/sc-37568/custom-host-preflights-can-be-declared-in branch

September 24, 2021 17:48

kwsorensen added a commit that referenced this pull request


          Revert "kURL allow custom vendor host preflight checks (#2133)"

6862c52

This reverts commit efb1766.

kwsorensen mentioned this pull request

Revert "kURL allow custom vendor host preflight checks" #2168

Merged

kwsorensen pushed a commit that referenced this pull request


          Revert "kURL allow custom vendor host preflight checks (#2133)" (#2168)

caea37f

This reverts commit efb1766.

kwsorensen added a commit that referenced this pull request


          Revert "Revert "kURL allow custom vendor host preflight checks (#2133)…

f1084e0

…" (#2168)"

This reverts commit caea37f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet