This repository was archived by the owner on May 31, 2025. It is now read-only.
Use boost::make_shared instead of new for constructing shared_ptrs#740
Closed
kartikmohta wants to merge 2 commits intoros:indigo-develfrom
kartikmohta:fix/use_make_shared
Closed
Use boost::make_shared instead of new for constructing shared_ptrs#740kartikmohta wants to merge 2 commits intoros:indigo-develfrom kartikmohta:fix/use_make_shared
kartikmohta wants to merge 2 commits intoros:indigo-develfrom
kartikmohta:fix/use_make_shared
Conversation
Member
|
@ros-pull-request-builder retest this please |
Member
|
@ros/ros_team Please review this. |
Member
|
Seems low risk to me. I would classify it as somewhat unnecessary though, because it isn't functionally different. +1 to merge at the next convenient time Thanks @kartikmohta! |
dirk-thomas
pushed a commit
that referenced
this pull request
Mar 1, 2016
Member
|
Thank you for the patch. I have squashed and merge the changes in 90b0eb7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rh-make_shared