-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate InteractiveMarkerDisplay #457
Conversation
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
Opening for visibility. This isn't quite ready for review as there are some things I'd still like to do:
For those interested in trying out the display, you can check out this branch and clone the interactive_markers package to your workspace: https://github.com/ros-visualization/interactive_markers/tree/ros2. I've ported the demos too. You can find them here: https://github.com/jacobperron/visualization_tutorials/tree/jacob/ros2 |
Added some simple tests for the new property. Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
This follows the tf2::BufferCoreInterface API, avoiding issues where third-party libraries are expecting to deal with tf2 exceptions rather than rviz specific exceptions (e.g. like interactive_markers). Signed-off-by: Jacob Perron <[email protected]>
Planning to add some tests still, but the rest is ready for review. |
The full communication reset isn't necessary. Signed-off-by: Jacob Perron <[email protected]>
...ins/include/rviz_default_plugins/displays/interactive_markers/interactive_marker_control.hpp
Outdated
Show resolved
Hide resolved
Not necessary in ROS 2 port of interactive_markers. Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
I've been working on tests, but it looks like we should add/extend mock objects. |
Sounds good to me. |
Closes #98
Depends on ros2/ros2#770
Some changes since ROS 1 based on discussion in ros-visualization/interactive_markers#42: