Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cox-analytics #7283

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Update cox-analytics #7283

merged 2 commits into from
Feb 16, 2025
+1 −1

Conversation

MoreBuchus
Copy link
Contributor

Updates to 1.0.2
Fixes varbit changes

@MoreBuchus
Update cox-analytics
Loading
Loading status checks…
2301a89
@runelite-github-app
Copy link

runelite-github-app bot commented Jan 25, 2025 •
edited
Loading

cox-analytics: 82cd1ebdc03dc0e80b3dba5a17bfb3b73c2ba465...f7bc06f16ee81ae91f7482dbf582a0bb85560200

@YvesW
Copy link
Member

YvesW commented Jan 25, 2025 •
edited
Loading

Please remove your System.io print function

Edit: goddamnit, that was a different plugin. You should remove it from cox-qol for the future probs.

@YvesW YvesW added waiting for author waiting for the pr author to make changes or respond to questions and removed waiting for author waiting for the pr author to make changes or respond to questions labels Jan 25, 2025
@LlemonDuck
Copy link
Contributor 

net.runelite.pluginhub.packager.PluginBuildException: cox-analytics: plugin uses terminally deprecated APIs:
Use ComponentID or InterfaceID instead of WidgetInfo or WidgetID

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 26, 2025
@MoreBuchus
Update cox-analytics
Loading
Loading status checks…
42a2dac
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 13, 2025
@MoreBuchus
Copy link
Contributor Author

Updated to use ComponentID

@LlemonDuck LlemonDuck merged commit 3d5b353 into runelite:master Feb 16, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MoreBuchus @YvesW @LlemonDuck