Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases: add missing artifacts #2033

Open
allentiak opened this issue Sep 10, 2024 · 4 comments
Open

Releases: add missing artifacts #2033

allentiak opened this issue Sep 10, 2024 · 4 comments
Assignees

Comments

@allentiak
Copy link
Member

Currently, the only artifact for releases is the source code.
Whereas this is certainly good for reproducibility purposes, it has no "every day" use case.

Ideally, it would be nice to add:

@allentiak allentiak self-assigned this Sep 10, 2024
@alexanderkiel
Copy link
Member

We can add a link to the Docker images, but not the Uberjar, because I don't linke people to run the Uberjar standalone.

@alexanderkiel alexanderkiel modified the milestone: v1.0.0 Sep 12, 2024
@Jolly5
Copy link

Jolly5 commented Nov 19, 2024

We can add a link to the Docker images, but not the Uberjar, because I don't linke people to run the Uberjar standalone.

If you don't like people to run the Uberjar, what is the preferred way of setting up a temporary test instance? E.g. for integration tests of ETL pipelines?

@alexanderkiel
Copy link
Member

We can add a link to the Docker images, but not the Uberjar, because I don't linke people to run the Uberjar standalone.

If you don't like people to run the Uberjar, what is the preferred way of setting up a temporary test instance? E.g. for integration tests of ETL pipelines?

Docker is always the preferred way to run Blaze, because with Docker, the JVM and the Libs that RocksDB needs are controllable. Is there anything that prevents you to use Docker in such an integration test scenario? If you look into the GitHub Action pipeline of the Blaze repo itself, it starts several Docker containers for integration tests of Blaze itself. Also in software components that use Blaze, like FLARE and TORCH we run the Blaze container even in JUnit tests using the Testcontainers library.

@Jolly5
Copy link

Jolly5 commented Nov 20, 2024

Docker is always the preferred way to run Blaze, because with Docker, the JVM and the Libs that RocksDB needs are controllable. Is there anything that prevents you to use Docker in such an integration test scenario? If you look into the GitHub Action pipeline of the Blaze repo itself, it starts several Docker containers for integration tests of Blaze itself. Also in software components that use Blaze, like FLARE and TORCH we run the Blaze container even in JUnit tests using the Testcontainers library.

Using docker containers for this purpose while keeping things flexible seemed difficult at me at first. But after looking it up I realized it's easier than I thought. Your comment still helps me and may help more people in the future, so thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants