Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Direct Download of Binary Content at the Binary Endpoint #2108

Closed
Tracked by #2009
alexanderkiel opened this issue Oct 8, 2024 · 0 comments · Fixed by #2119
Closed
Tracked by #2009

Implement Direct Download of Binary Content at the Binary Endpoint #2108

alexanderkiel opened this issue Oct 8, 2024 · 0 comments · Fixed by #2119
Assignees
Milestone

Comments

@alexanderkiel
Copy link
Member

alexanderkiel commented Oct 8, 2024

Scaffolding:

  • in blaze.rest-api.routes introduce a new :response-type called :binary
    • use that new response type in wrap-output to call a new middleware function called blaze.middleware.fhir.output/wrap-binary-output
    • in resource-route tag the route with :response-type :binary if the name is "Binary"
  • create a new middleware function called blaze.middleware.fhir.output/wrap-binary-output
    • it should call request-format like wrap-output but only handle :fhir+json and :fhir+xml in the normal way and return the binary content otherwise
  • the binary handling should take the :data base64 string of the Binary resource, base64 decode it and output it as body and also set the :contentType string as Content-Type header

For tests:

  • unit tests in blaze.middleware.fhir.output-test
  • integration test in GitHub Actions by creating a new Bash script in .github/scripts
    • generate-large-binary-resource.sh
    • create-patient.sh

Part of #2009.

@alexanderkiel alexanderkiel added the enhancement New feature or request label Oct 8, 2024
@alexanderkiel alexanderkiel added this to the v0.31.0 milestone Oct 8, 2024
@alexanderkiel alexanderkiel modified the milestones: v0.30.1, v0.31.0 Oct 10, 2024
allentiak added a commit that referenced this issue Oct 21, 2024
* also improve clojuredoc strings
allentiak added a commit that referenced this issue Oct 21, 2024
* also improve clojuredoc strings
allentiak added a commit that referenced this issue Oct 22, 2024
* also improve clojuredoc strings
allentiak added a commit that referenced this issue Oct 22, 2024
* also improve clojuredoc strings
allentiak added a commit that referenced this issue Oct 22, 2024
allentiak added a commit that referenced this issue Oct 22, 2024
allentiak added a commit that referenced this issue Oct 22, 2024
allentiak added a commit that referenced this issue Oct 23, 2024
allentiak added a commit that referenced this issue Oct 24, 2024
allentiak added a commit that referenced this issue Oct 25, 2024
allentiak added a commit that referenced this issue Nov 1, 2024
allentiak added a commit that referenced this issue Nov 5, 2024
allentiak added a commit that referenced this issue Nov 11, 2024
allentiak added a commit that referenced this issue Nov 11, 2024
allentiak added a commit that referenced this issue Nov 12, 2024
allentiak added a commit that referenced this issue Nov 13, 2024
allentiak added a commit that referenced this issue Nov 13, 2024
allentiak added a commit that referenced this issue Nov 13, 2024
allentiak added a commit that referenced this issue Nov 13, 2024
allentiak added a commit that referenced this issue Nov 13, 2024
allentiak added a commit that referenced this issue Nov 14, 2024
allentiak added a commit that referenced this issue Nov 19, 2024
allentiak added a commit that referenced this issue Nov 20, 2024
allentiak added a commit that referenced this issue Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants