Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Performance of JSON Unforming #308

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Improve Performance of JSON Unforming #308

merged 1 commit into from
Jan 3, 2021

Conversation

alexanderkiel
Copy link
Member

Instead of literal unforming of the internal FHIR data structures to a format usable by most JSON serializers like Cheshire, I just implement the JSONable of Cheshire directly at the primitive types. So I don't have to rebuild the maps representing non-primitive types to the extend previously.

@alexanderkiel alexanderkiel added the performance Performance improvement label Jan 2, 2021
@alexanderkiel alexanderkiel added this to the v0.11 milestone Jan 2, 2021
@alexanderkiel alexanderkiel self-assigned this Jan 2, 2021
@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #308 (fee20f4) into develop (1544f67) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #308      +/-   ##
===========================================
+ Coverage    87.47%   87.78%   +0.30%     
===========================================
  Files          196      196              
  Lines        12062    12106      +44     
  Branches       482      483       +1     
===========================================
+ Hits         10551    10627      +76     
+ Misses        1029      996      -33     
- Partials       482      483       +1     
Impacted Files Coverage Δ
...r-structure/src/blaze/fhir/spec/type/protocols.clj 100.00% <ø> (ø)
...odules/fhir-structure/src/blaze/fhir/spec/impl.clj 93.95% <100.00%> (ø)
...odules/fhir-structure/src/blaze/fhir/spec/type.clj 87.60% <100.00%> (+7.05%) ⬆️
...dules/interaction/src/blaze/interaction/update.clj 95.52% <0.00%> (-1.50%) ⬇️

Instead of literal unforming of the internal FHIR data structures to a
format usable by most JSON serializers like Cheshire, I just implement
the JSONable of Cheshire directly at the primitive types. So I don't
have to rebuild the maps representing non-primitive types to the extend
previously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant