Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Instance and Versioned URLs by Hand #339

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

alexanderkiel
Copy link
Member

I used reitit to generate the type, instance and versioned instance URL.
However reitit is very slow at encoding path parameters. because FHIR
ID's and our VID's are already URL safe, encoding isn't necessary. Also
the URL schema is fixed, so a decided to simply create them by hand. We
could revert to the old model if
metosin/reitit#477 is solved.

@alexanderkiel alexanderkiel self-assigned this Mar 4, 2021
@alexanderkiel alexanderkiel added this to the v0.11 milestone Mar 4, 2021
@alexanderkiel alexanderkiel added the performance Performance improvement label Mar 4, 2021
I used reitit to generate the type, instance and versioned instance URL.
However reitit is very slow at encoding path parameters. because FHIR
ID's and our VID's are already URL safe, encoding isn't necessary. Also
the URL schema is fixed, so a decided to simply create them by hand. We
could revert to the old model if
metosin/reitit#477 is solved.
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #339 (a98bbc2) into develop (ce1671f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #339   +/-   ##
========================================
  Coverage    88.38%   88.38%           
========================================
  Files          200      200           
  Lines        12419    12414    -5     
  Branches       466      465    -1     
========================================
- Hits         10976    10972    -4     
  Misses         977      977           
+ Partials       466      465    -1     
Impacted Files Coverage Δ
modules/rest-util/src/blaze/handler/fhir/util.clj 100.00% <100.00%> (ø)
.../interaction/src/blaze/interaction/transaction.clj 95.98% <0.00%> (+0.40%) ⬆️

@alexanderkiel alexanderkiel merged commit e60b84e into develop Mar 4, 2021
@alexanderkiel alexanderkiel deleted the instance-url branch March 4, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant