Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Transaction Performance #373

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

alexanderkiel
Copy link
Member

We relied on the resource cache to transfer resources from the submit
side of the transaction handling to the resource indexing side. However
a cache isn't well suited to hold entries that aren't already accessed.
So the hit ratio wasn't near 100 % as it should for this use case.

To improve on this situation, we now maintain a separate resource cache
in the database node.

Also did many more improvements and updates.

@alexanderkiel alexanderkiel self-assigned this Apr 26, 2021
@alexanderkiel alexanderkiel added this to the v0.11 milestone Apr 26, 2021
@alexanderkiel alexanderkiel force-pushed the transaction-performance branch 2 times, most recently from 899b12c to 46de8fa Compare April 26, 2021 19:51
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #373 (fb94b62) into develop (b2026b8) will increase coverage by 0.11%.
The diff coverage is 95.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #373      +/-   ##
===========================================
+ Coverage    89.27%   89.39%   +0.11%     
===========================================
  Files          206      207       +1     
  Lines        12845    12847       +2     
  Branches       451      454       +3     
===========================================
+ Hits         11468    11485      +17     
+ Misses         926      908      -18     
- Partials       451      454       +3     
Impacted Files Coverage Δ
.../db-resource-store/src/blaze/db/resource_store.clj 100.00% <ø> (ø)
...-resource-store/src/blaze/db/resource_store/kv.clj 90.00% <0.00%> (ø)
...gistry/src/blaze/db/search_param_registry_spec.clj 83.33% <0.00%> (ø)
...am-registry/src/blaze/db/search_param_registry.clj 87.12% <83.33%> (+1.05%) ⬆️
...ules/db/src/blaze/db/impl/index/resource_as_of.clj 97.60% <84.61%> (-0.88%) ⬇️
modules/fhir-path/src/blaze/fhir_path.clj 88.00% <90.19%> (-0.59%) ⬇️
...dules/db/src/blaze/db/impl/search_param/string.clj 91.37% <90.90%> (-2.47%) ⬇️
modules/async/src/blaze/async/comp.clj 100.00% <100.00%> (ø)
modules/async/src/blaze/async/comp_spec.clj 100.00% <100.00%> (ø)
...urce-store/src/blaze/db/resource_store/kv/spec.clj 100.00% <100.00%> (ø)
... and 17 more

@alexanderkiel alexanderkiel force-pushed the transaction-performance branch 2 times, most recently from bcf8fe5 to 5094bdb Compare April 27, 2021 12:43
We relied on the resource cache to transfer resources from the submit
side of the transaction handling to the resource indexing side. However
a cache isn't well suited to hold entries that aren't already accessed.
So the hit ratio wasn't near 100 % as it should for this use case.

To improve on this situation, we now maintain a separate resource cache
in the database node.

Also did many more improvements and updates.
@alexanderkiel alexanderkiel force-pushed the transaction-performance branch from 5094bdb to fb94b62 Compare April 27, 2021 13:17
@alexanderkiel alexanderkiel merged commit 5588959 into develop Apr 27, 2021
@alexanderkiel alexanderkiel deleted the transaction-performance branch April 27, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant