Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Download of Binary Resources #2119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement Download of Binary Resources #2119

wants to merge 1 commit into from
+251 −12

Conversation

allentiak
Copy link
Member

Fixes #2108

alexanderkiel
alexanderkiel requested changes Oct 14, 2024
View reviewed changes
docs/implementation/fhir-data-model.md Outdated Show resolved Hide resolved
modules/rest-api/src/blaze/rest_api/routes.clj Outdated Show resolved Hide resolved
modules/rest-api/src/blaze/rest_api/routes.clj Outdated Show resolved Hide resolved
modules/fhir-structure/src/blaze/fhir/spec.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/fhir/output.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/fhir/output.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/fhir/output.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/fhir/resource.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/output.clj Outdated Show resolved Hide resolved
modules/rest-util/test/blaze/middleware/fhir/output_test.clj Outdated Show resolved Hide resolved
@allentiak allentiak force-pushed the binary-download branch 3 times, most recently from 8253d14 to 4b8e92b Compare October 15, 2024 12:00
@allentiak allentiak force-pushed the binary-download branch 4 times, most recently from d1e1267 to 3f6a998 Compare October 16, 2024 13:14
allentiak
allentiak commented Oct 17, 2024
View reviewed changes
Copy link
Member Author

@allentiak allentiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just re-reviewed my own changes.
Couldn't do that without writing something here...)

@allentiak allentiak force-pushed the binary-download branch 6 times, most recently from 8f87f27 to c1e59ba Compare October 18, 2024 11:33
@allentiak allentiak mentioned this pull request Oct 18, 2024
Open
2 tasks
@allentiak allentiak changed the title Binary download Binary Download Oct 18, 2024
@allentiak allentiak mentioned this pull request Oct 18, 2024
Merged
@allentiak allentiak marked this pull request as ready for review October 21, 2024 18:58
@alexanderkiel alexanderkiel added this to the v0.31.0 milestone Nov 20, 2024
@allentiak allentiak marked this pull request as draft November 20, 2024 17:02
@allentiak allentiak force-pushed the binary-download branch 3 times, most recently from a2229ca to b0fdc30 Compare November 22, 2024 14:05
@allentiak allentiak removed the request for review from alexanderkiel November 22, 2024 14:10
@allentiak allentiak marked this pull request as ready for review November 27, 2024 09:52
@allentiak allentiak changed the title Binary Download Implement Download of Binary Resources Nov 27, 2024
@allentiak allentiak force-pushed the binary-download branch 14 times, most recently from 64ca712 to e5cf56c Compare December 3, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderkiel alexanderkiel alexanderkiel requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@allentiak allentiak

Labels
enhancement New feature or request module:rest-api module:rest-util
Projects
None yet
Milestone
v0.31.0
Development

Successfully merging this pull request may close these issues.

Implement Direct Download of Binary Content at the Binary Endpoint
2 participants
@allentiak @alexanderkiel