Intern Uri, Canonical, Code, Coding and CodeableConcept #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #628 +/- ##
========================================
Coverage 93.42% 93.42%
========================================
Files 235 236 +1
Lines 13875 13911 +36
Branches 343 343
========================================
+ Hits 12963 12997 +34
- Misses 569 571 +2
Partials 343 343
|
9cda0e1
to
6b98bca
Compare
In FHIR, some values repeat in many resources. First uri's are used as system's in Codings and Identifiers. Second canonical values are used to refer to other resources. Third codes are often the same for a large number of resources. Last, Coding and CodeableConcept contain system and code values and are also often the same in it's entirety. By interning instances of those values, only one instance will resist in memory as opposed to many. Because all values are immutable, there is no risk in sharing instances. The memory savings are about 50 % for Synthea BMI Observations.
6b98bca
to
ac4edd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FHIR, some values repeat in many resources. First uri's are used as system's in Codings and Identifiers. Second canonical values are used to refer to other resources. Third codes are often the same for a large number of resources. Last, Coding and CodeableConcept contain system and code values and are also often the same in it's entirety.
By interning instances of those values, only one instance will resist in memory as opposed to many. Because all values are immutable, there is no risk in sharing instances. The memory savings are about 50 % for Synthea BMI Observations.