Fix Server Errors Because of Unencoded Error Outputs #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problem was introduced in v0.17.1. Versions of Blaze before v0.17.1 are not effected. HTTP Error Outputs with status codes 404 and 405 were not encoded to either JSON or XML, leading to an error in Jersey, leading to a 500. This commit also introduces redirecting requests including a leading slash to ones without one.
Codecov Report
@@ Coverage Diff @@
## develop #706 +/- ##
========================================
Coverage 93.64% 93.64%
========================================
Files 237 237
Lines 14173 14174 +1
Branches 356 356
========================================
+ Hits 13272 13273 +1
Misses 545 545
Partials 356 356
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem was introduced in v0.17.1. Versions of Blaze before v0.17.1 are not effected.
HTTP Error Outputs with status codes 404 and 405 were not encoded to either JSON or XML, leading to an error in Jetty, leading to a 500.
This commit also introduces redirecting requests including a leading slash to ones without one.