-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serrors: Add nogo check #3213
serrors: Add nogo check #3213
Conversation
This changes adds a linter that ensures the varargs input to serrors.{New, WithCtx, Wrap, WrapStr} is well-formed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove 'changes' from the description of the PR.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
WORKSPACE, line 293 at r1 (raw file):
name = "com_github_oncilla_gochecks", commit = "d6344eb0440fcd1b62d95b9e0eb64f1350638420", importpath = "github.com/oncilla/gochecks",
Add at least a one-line readme to the GitHub repo so that it's obvious what it is for.
WORKSPACE, line 293 at r1 (raw file): Previously, sustrik (Martin Sustrik) wrote…
I would suggest also that this goes into anapaya/scion space in case someone would like to make a change. |
As this is a personal project I'm doing outside of work, I don't think this should be in scionproto. |
WORKSPACE, line 293 at r1 (raw file): Previously, Oncilla wrote…
ack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
This changes adds a nogo rule that ensures the varargs input to
serrors.{New, WithCtx, Wrap, WrapStr} is well-formed.
fixes #3196
This change is