Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrustStore: Fix flaky unit test #3216

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Oct 3, 2019

The "TRC in database, outside graceperiod" test could fail when the
crypto material was generated less than a second before the test is run.

This change makes sure the test is no longer time dependent.

fixes #3214


This change is Reviewable

The "TRC in database, outside graceperiod" test could fail when the
crypto material was generated less than a second before the test is run.

This change makes sure the test is no longer time dependent.

fixes scionproto#3214
@oncilla oncilla requested a review from sgmonroy October 3, 2019 13:43
Copy link
Contributor

@sgmonroy sgmonroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit 58f17d1 into scionproto:master Oct 3, 2019
@oncilla oncilla deleted the pub-fix-crypto-proviuder branch October 3, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UT: crypto provider test sometimes fails
2 participants