Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExpTime() to Path interface #3229

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Add ExpTime() to Path interface #3229

merged 2 commits into from
Oct 8, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Oct 7, 2019

This change is Reviewable

@scrye scrye self-requested a review October 7, 2019 15:05
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)


go/lib/snet/router.go, line 141 at r1 (raw file):

	// ExpTime returns the expiration time of the path. If the result is zero,
	// expiration time is unknown.
	ExpTime() uint32

uint32 is very awkward to work with, especially because semantics are not clear without digging them up. This should be changed to return time.Time.

Copy link
Contributor Author

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @scrye)


go/lib/snet/router.go, line 141 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

uint32 is very awkward to work with, especially because semantics are not clear without digging them up. This should be changed to return time.Time.

Done.

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 0555fe4 into scionproto:master Oct 8, 2019
@sustrik sustrik deleted the mtu branch October 8, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants