[MRG+2] [logformatter] 'flags' format spec backward compatibility #2649
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass 'flags' kwarg to logger so that it is compatible with old format of CRAWLEDMSG.
0c5f9a6 to
0f2a5cd
Compare
kmike
reviewed
Mar 14, 2017
scrapy/logformatter.py
Outdated
| @@ -43,6 +43,7 @@ def crawled(self, request, response, spider): | |||
| 'request_flags' : request_flags, | |||
| 'referer': referer_str(request), | |||
| 'response_flags': response_flags, | |||
| 'flags': response_flags | |||
There was a problem hiding this comment.
Could you please add a comment which says that flags alias is for backwards compatibility with Scrapy < 1.4?
kmike
reviewed
Mar 14, 2017
tests/test_logformatter.py
Outdated
| @@ -64,5 +64,32 @@ def test_scraped(self): | |||
| assert all(isinstance(x, six.text_type) for x in lines) | |||
| self.assertEqual(lines, [u"Scraped from <200 http://www.example.com>", u'name: \xa3']) | |||
|
|
|||
|
|
|||
| class LogFormatterSubclass(LogFormatter): | |||
| # Formatter with format spec that is same as in Scrapy before 1.3 version. | |||
There was a problem hiding this comment.
I think response.flags will be released as a part of 1.4, not 1.3.x
Codecov Report
@@ Coverage Diff @@
## master #2649 +/- ##
==========================================
+ Coverage 84.25% 84.26% +0.01%
==========================================
Files 162 162
Lines 9106 9106
Branches 1350 1350
==========================================
+ Hits 7672 7673 +1
Misses 1174 1174
+ Partials 260 259 -1
Continue to review full report at Codecov.
|
|
Thanks @pawelmhm, looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass 'flags' kwarg to logger so that it is compatible with old format of CRAWLEDMSG. fixes #2647