feat: build and publish test version on PRs #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 5, 2023 08:58
It is done in the PR publish workflow
yknl
reviewed
Jul 5, 2023
yknl
reviewed
Jul 5, 2023
|
yknl
reviewed
Jul 5, 2023
| @@ -2,7 +2,7 @@ name: Build | |||
|
|
|||
| on: | |||
| pull_request: | |||
| branches: [main, develop] | |||
| branches: [main] | |||
There was a problem hiding this comment.
Should we have develop here? Since PRs are opened against develop.
There was a problem hiding this comment.
The new workflow does this as one of its steps, so I took it out of here since it would be doing the same thing twice.
victorkirov
commented
Jul 7, 2023
Comment on lines
+18
to
+29
| test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 | ||
| cache: npm | ||
| - run: npm ci | ||
| # TODO: enable linting once ready | ||
| # - run: npm run lint | ||
| - run: npm test |
There was a problem hiding this comment.
@yknl this is the bit that the other workflow is doing
yknl
approved these changes
Jul 10, 2023
teebszet
pushed a commit
that referenced
this pull request
Oct 8, 2024
…contract-call-fees Update dependencies and add Stacks api provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a publish step to PR builds (or if action is run manually on any branch) which publishes a test build to the package repository with a version
<current_package_version>-<commit_short_sha>.