fix: unit test and fix fetchStxPendingTxData function #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yknl
reviewed
Aug 9, 2023
| @@ -151,20 +151,24 @@ export function parseBtcTransactionData( | |||
| return parsedTx; | |||
| } | |||
|
|
|||
| export function deDuplicatePendingTx({ | |||
| export function getUniquePendingTx({ | |||
There was a problem hiding this comment.
Is deDuplicatePendingTx used anywhere else? Potentially directly imported by the app and extension?
There was a problem hiding this comment.
@yknl xverse-core doesn't export the helper.ts functions, so the export is only available locally to the package:
api/index.ts
export * from './btc';
export * from './xverse';
export * from './stacks';
export * from './gamma';
export * from './ordinals';
export * from './esplora/esploraAPiProvider';
export * from './ordinals/provider';
yknl
approved these changes
Aug 9, 2023
|
renamed to: #205 |
teebszet
added a commit
that referenced
this pull request
Oct 8, 2024
* refactor: gather fungible token derived state into one place and add unit tests * refactor: add visible back and deprecate it so PR core is not breaking change * chore: readability Co-authored-by: Victor Kirov <[email protected]> * fix: move the logic to always support runes tokens to be clearer * chore: add comments and readability * chore: extend manageTokens type to cater for tokens that were not set yet --------- Co-authored-by: Victor Kirov <[email protected]> Co-authored-by: fede erbes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
Issue Link: https://linear.app/xverseapp/issue/ENG-2581/unit-test-and-fix-fetch-fetchpendingstxtransactions-function
Context Link (if applicable):
🔄 Changes
Does this PR introduce a breaking change?
Changes:
Impact:
🖼 Screenshot / 📹 Video
✅ Review checklist
Please ensure the following are true before merging: