Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim/enforce prettier and eslint on precommit #230

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

teebszet
Copy link
Member

🔘 PR Type

What kind of change does this PR introduce?

  • Code style update (formatting, local variables)
  • Other... Please describe: enforcing precommit hooks

📜 Background

Improved code hygiene

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, code styling only (backwards compatible)

Changes:

  • run prettier --write (no functional code changes, just consistent code style)
  • add husky precommit hooks for eslint and prettier

Impact:

  • no functional changes

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@github-actions
Copy link
Contributor

Test this PR with npm i @secretkeylabs/[email protected]

@DuskaT021 DuskaT021 self-requested a review August 31, 2023 11:29
Copy link
Contributor

@dhriaznov dhriaznov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good 🧹✨

@dhriaznov
Copy link
Contributor

Should we merge it? @teebszet

@teebszet teebszet merged commit d8691a4 into develop Sep 4, 2023
3 checks passed
@teebszet teebszet deleted the tim/enforce-prettier-and-eslint-on-precommit branch September 4, 2023 06:47
@teebszet teebszet restored the tim/enforce-prettier-and-eslint-on-precommit branch October 4, 2023 03:37
@teebszet teebszet deleted the tim/enforce-prettier-and-eslint-on-precommit branch October 4, 2023 03:38
teebszet pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants