Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor and improve bip322 tests, remove unused functions #231

Merged

Conversation

victorkirov
Copy link
Member

🔘 PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

📜 Background

Our test didn't actually validate that the bip322 signing function was working, and the additional verify method caused confusion in the main bip322 file as it was test-related only.

🔄 Changes

Does this PR introduce a breaking change?

  • No, Bug fixes (backwards compatible)

Changes:

  • Message signing was cleaned up and better tested
  • No changes to code that is being used

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@victorkirov victorkirov self-assigned this Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Test this PR with npm i @secretkeylabs/[email protected]

@m-aboelenein m-aboelenein merged commit 1c05d54 into develop Sep 11, 2023
3 checks passed
@m-aboelenein m-aboelenein deleted the victor/eng-2809-investigate-js-validaiton-of-bip-322 branch September 11, 2023 20:45
@yknl yknl mentioned this pull request Sep 14, 2023
8 tasks
teebszet pushed a commit that referenced this pull request Nov 5, 2024
Co-authored-by: GitHub Actions Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants