Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add additional param to restoreWalletWithAccounts to handle mo… #238

Closed

Conversation

fedeerbes
Copy link
Contributor

…bile client

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.

Issue Link: #[issue_number]
Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • What has been modified, added, or removed
  • Which are breaking changes

Impact:

  • How it improves performance, fixes bugs, adds functionality, etc.
  • Impact on downstream apps, link to issues or PRs for migration
  • What to test

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@github-actions
Copy link
Contributor

Test this PR with npm i @secretkeylabs/[email protected]

@m-aboelenein
Copy link
Member

@fedeerbes i am seeing contradictions here regarding the performance in question through testing i found that using map is faster in terms of raw performance with the downside being the ui being blocked for the first iteration this problem can be resolved by controlling concurrency instead of generating the accounts one by one by using a package like https://www.npmjs.com/package/p-queue or by offloading the work entirely to a separate process for example https://github.com/joltup/react-native-threads

@fedeerbes
Copy link
Contributor Author

closing this as discussed in 13/09 standup. Performance optimization for account derivation on mobile will be tackled in the future with a better solution.

@fedeerbes fedeerbes closed this Sep 13, 2023
@fedeerbes fedeerbes deleted the chore/restore-mobile-account-derivation-performance branch September 13, 2023 08:45
teebszet pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants