Add icons for drains to bay or ocean #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,7 +49,7 @@ | |||
| t.string "name" | |||
| t.decimal "lat", precision: 16, scale: 14, null: false | |||
| t.decimal "lng", precision: 17, scale: 14, null: false | |||
| t.string "city_id" | |||
| t.integer "city_id" | |||
There was a problem hiding this comment.
Not sure how this snuck in there -- you may need to run a ./bin/rake db:migrate locally as having it as a string is correct.
Bring it up to date -- missed db:migrate
Currently just hardcoding the one special case that we have, but we should generalize if we add more.
75d9ba1
to
de7e0ff
Compare
|
@jasonlally pushed de7e0ff to add the link, let me know what you think! Looks like: |
|
👍 I'll merge. We may add to the successfully adopted info window, but I'll ask @jeanwalshie and that's something I can do now with this in place. |
jasonlally
added a commit
that referenced
this pull request
Jan 17, 2016
Add icons for drains to bay or ocean
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the bay/ocean icons to the map and legend.
@jszwedko - as we discussed I want to address #66 by adding a link that only comes through on the infowindows for bay icons. I need your much better rails skills on this particular part.
The link can say: This drain is special! Learn why.
And go to: http://sfwater.org/index.aspx?page=399
I think it makes the most sense to have a method to check for parameters on the things so we could pass in any attribute and parameter and it would return true or false. Then we can have a general method for providing different behaviors based on attributes of a particular drain.
Then on the view check for MS4 on system_use_code and display the link only for those.
Hopefully that makes sense.